Request a Demo
Home   >   mailing lists

[PATCH] Fix POSIX compliance in pgwin32_unsetenv() - Mailing list pgsql-hackers

From Bryan Green
Subject [PATCH] Fix POSIX compliance in pgwin32_unsetenv()
Date
Msg-id b6a1e52b-d808-4df7-87f7-2ff48d15003e@gmail.com
Whole thread Raw
List pgsql-hackers
Tree view 
I noticed that pgwin32_unsetenv() in src/port/win32env.c lacks the input 
validation that its sibling function pgwin32_setenv() has (lines 126-132).

Without these checks, the function will crash on NULL input via 
strlen(NULL), and will accept empty strings or strings containing '=' in 
violation of POSIX.1-2008.

The attached patch adds the same validation that pgwin32_setenv already 
does, making the two functions consistent.  This is purely defensive - 
it only affects callers passing invalid arguments.

regards,

Bryan Green
Attachment

pgsql-hackers by date:

Previous
From: Philip Alger
Date:
Subject: Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement
Next
From: KAZAR Ayoub
Date:
Subject: Re: Speed up COPY FROM text/CSV parsing using SIMD