Re: Use FD_CLOEXEC on ListenSockets (was Re: Refactoring backend fork+exec code) - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Use FD_CLOEXEC on ListenSockets (was Re: Refactoring backend fork+exec code)
Date
Msg-id b666fe49-e700-4fc7-0d34-41e51849a9b3@iki.fi
Whole thread Raw
In response to Re: Use FD_CLOEXEC on ListenSockets (was Re: Refactoring backend fork+exec code)  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Use FD_CLOEXEC on ListenSockets (was Re: Refactoring backend fork+exec code)
List pgsql-hackers
On 29/08/2023 09:58, Heikki Linnakangas wrote:
> On 29/08/2023 09:21, Heikki Linnakangas wrote:
>> Thinking about this some more, the ListenSockets array is a bit silly
>> anyway. We fill the array starting from index 0, always append to the
>> end, and never remove entries from it. It would seem more
>> straightforward to keep track of the used size of the array. Currently
>> we always loop through the unused parts too, and e.g.
>> ConfigurePostmasterWaitSet() needs to walk the array to count how many
>> elements are in use.
> 
> Like this.

This seems pretty uncontroversial, and I heard no objections, so I went 
ahead and committed that.

-- 
Heikki Linnakangas
Neon (https://neon.tech)




pgsql-hackers by date:

Previous
From: Dave Cramer
Date:
Subject: Change of behaviour for creating same type name in multiple schemas
Next
From: Gurjeet Singh
Date:
Subject: Re: Good News Everyone! + feature proposal