Re: Don't cast away const where possible - Mailing list pgsql-hackers

On 18.12.25 14:55, Bertrand Drouvot wrote:
> Some functions are casting away the const qualifiers from their signatures in
> local variables.

@@ -1304,8 +1304,8 @@ merge_overlapping_ranges(FmgrInfo *cmp, Oid colloid,
  static int
  compare_distances(const void *a, const void *b)
  {
-       DistanceValue *da = (DistanceValue *) a;
-       DistanceValue *db = (DistanceValue *) b;
+       const DistanceValue *da = (const DistanceValue *) a;
+       const DistanceValue *db = (const DistanceValue *) b;

I wonder if the better fix here wouldn't be to get rid of the cast. 
It's not necessary, and without it the compiler would automatically warn 
about qualifier mismatches.  These comparison functions seem to be a 
common pattern.