Request a Demo
Home   >   mailing lists

Re: backend/nodes cleanup: Move loop variables definitions into for statement - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: backend/nodes cleanup: Move loop variables definitions into for statement
Date
Msg-id b45536be-b978-4038-8fd7-743c0f1285f4@eisentraut.org
Whole thread Raw
In response to Re: backend/nodes cleanup: Move loop variables definitions into for statement  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: backend/nodes cleanup: Move loop variables definitions into for statement
List pgsql-hackers
Tree view 
On 19.11.25 11:32, Chao Li wrote:
> On Wed, Nov 19, 2025 at 5:36 PM Peter Eisentraut <peter@eisentraut.org 
> <mailto:peter@eisentraut.org>> wrote:
> 
> 
> 
>     In a couple of cases, you are changing the type of the loop variable
>     from Size to int.  I would not expect such a change in a patch of this
>     nature.  If you have a reason to change it, please explain it (but I
>     doubt the change is correct).
> 
> 
> That was a mistake. I fixed it in v3.

Still not correct in outDatum().

pgsql-hackers by date:

Previous
From: Bertrand Drouvot
Date:
Subject: Re: get rid of Pointer type, mostly
Next
From: "Greg Burd"
Date:
Subject: Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB ​barriers