Postgres Pro
Downloads
Home   >   mailing lists

Re: Support TRUNCATE triggers on foreign tables - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Support TRUNCATE triggers on foreign tables
Date
Msg-id b2f6d778-7aff-5e0b-4e09-d0b76fa25e9c@oss.nttdata.com
Whole thread Raw
In response to Support TRUNCATE triggers on foreign tables  (Yugo NAGATA <nagata@sraoss.co.jp>)
Responses Re: Support TRUNCATE triggers on foreign tables
List pgsql-hackers
Tree view 

On 2022/06/30 19:38, Yugo NAGATA wrote:
> Hello,
> 
> I propose supporting TRUNCATE triggers on foreign tables
> because some FDW now supports TRUNCATE. I think such triggers
> are useful for audit logging or for preventing undesired
> truncate.
> 
> Patch attached.

Thanks for the patch! It looks good to me except the following thing.

        <entry align="center"><command>TRUNCATE</command></entry>
        <entry align="center">—</entry>
-      <entry align="center">Tables</entry>
+      <entry align="center">Tables and foreign tables</entry>
       </row>

You added "foreign tables" for BEFORE statement-level trigger as the above, but ISTM that you also needs to do that for
AFTERstatement-level trigger. No?
 

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: archive modules
Next
From: Fujii Masao
Date:
Subject: Re: Add a test for "cannot truncate foreign table"