Re: [PATCH] Timestamp for a XLOG_BACKUP_END WAL-record - Mailing list pgsql-hackers

From Andrey V. Lepikhov
Subject Re: [PATCH] Timestamp for a XLOG_BACKUP_END WAL-record
Date
Msg-id b20370b0-7a55-d3c5-d75e-db8090979ad5@postgrespro.ru
Whole thread Raw
In response to Re: [PATCH] Timestamp for a XLOG_BACKUP_END WAL-record  (Andres Freund <andres@anarazel.de>)
Responses Re: [PATCH] Timestamp for a XLOG_BACKUP_END WAL-record  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers

On 10.07.2018 06:45, Andres Freund wrote:
> Hi,
> 
> On 2018-07-10 06:41:32 +0500, Andrey V. Lepikhov wrote:
>> This functionality is needed in practice when we have to determine a
>> recovery time of specific backup.
> 
> What do you mean by "recovery time of specific backup"?
> 

recovery time - is a time point where backup of PostgreSQL database 
instance was made.
Performing database recovery, we want to know what point in time the 
restored database will correspond to.
This functionality refers to improving the usability of pg_basebackup 
and pg_probackup utilities.

> 
>> This code developed in compatibility with WAL segments, which do not have a
>> timestamp in a XLOG_BACKUP_END record.
> 
> I don't understand what "compatibility with WAL segments" could mean?
> And how are WAL segments related to "XLOG_BACKUP_END record", except as
> to how every WAL record is related? Are you thinking about the switch
> records?
> 

In this case 'compatibility' means that patched postgres codes 
(pg_basebackup, pg_probackup, pg_waldump etc) will correctly read WAL 
segments which not contains a timestamp field in XLOG_BACKUP_END record.

> Greetings,
> 
> Andres Freund
> 

-- 
Andrey Lepikhov
Postgres Professional:
https://postgrespro.com
The Russian Postgres Company


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Changing WAL Header to reduce contention duringReserveXLogInsertLocation()
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] PoC plpgsql - possibility to force custom or genericplan