Re: ISN extension - wrong volatility level for isn_weak() function - Mailing list pgsql-bugs

From Viktor Holmberg
Subject Re: ISN extension - wrong volatility level for isn_weak() function
Date
Msg-id b08ed3b6-eba7-47f5-b354-5e4ec1fb8632@Spark
Whole thread Raw
In response to Re: ISN extension - wrong volatility level for isn_weak() function  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: ISN extension - wrong volatility level for isn_weak() function
List pgsql-bugs
Oh, sorry! Don’t know what I was doing there - not used to this patch based workflow. Here comes the real patch.
This now uses the GUC - that was a lot easier than I thought.
One thing I couldn’t figure out: Should I add some sort of change log somewhere, describing what changed in version 1.3 of the ISN extension? If so, where?

/Viktor Holmberg
On 15 Mar 2025 at 16:22 +0000, Tom Lane <tgl@sss.pgh.pa.us>, wrote:
Viktor Holmberg <v@viktorh.net> writes:
On 14 Mar 2025 at 16:18 +0000, Tom Lane <tgl@sss.pgh.pa.us>, wrote:
No, we'd need to create an update script that uses ALTER FUNCTION.
Extension scripts are basically frozen once shipped.

Ah, thanks for the clarification. I’ve attached a patch that fixes the volatility. I thought it best to at least get some feedback on that before I try to dust off my C knowledge and try to fix the GUC stuff.

Uh .. looks like you attached a patch for something else altogether.

If you want a sample extension-updating patch to look at, you
could see 44ba2920644903d7dfceda810e5facdbcbab58a8, or lots of
other examples.

regards, tom lane
Attachment

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #18845: DEREF_OF_NULL.RET guc_malloc possibly returns NULL
Next
From: Tom Lane
Date:
Subject: Re: ISN extension - wrong volatility level for isn_weak() function