Re: pgstat: allow a stats kind to use its own dedicated dsa/dshash - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pgstat: allow a stats kind to use its own dedicated dsa/dshash
Date
Msg-id asdLgE3PngAqHjI6@paquier.xyz
Whole thread
In response to Re: pgstat: allow a stats kind to use its own dedicated dsa/dshash  (Sami Imseih <samimseih.pg@gmail.com>)
Responses Re: pgstat: allow a stats kind to use its own dedicated dsa/dshash
List pgsql-hackers
On Wed, Oct 07, 2026 at 04:55:21PM -0500, Sami Imseih wrote:
> Done.  v4 is split into two patches.

I have spent some time on that, still in the middle of it, and for now
I am attaching my edits as of a v5-0003 that can apply on top of your
set of two patches (re-attached, these are untouched).

Another doubt that I have is about test_custom_stats_var_is_own_hash()
and its limited value.  It is only a check that mirrors if a custom
stats kind uses its own_hash or not, but that does not seem worthwhile
to me due to the backend side restrictions already in place, so I'd be
tempted to drop it, keeping the test module focused on what it is
doing (insert, drops, create, etc.).
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Assert failure in find_var_for_subquery_tle
Next
From: David Geier
Date:
Subject: Re: Improving scalability of Parallel Bitmap Heap/Index Scan