Re: injection_points: canceled or terminated waiters leak their wait slots - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: injection_points: canceled or terminated waiters leak their wait slots
Date
Msg-id arrw8isOSbfkK5Fd@paquier.xyz
Whole thread
In response to Re: injection_points: canceled or terminated waiters leak their wait slots  (Zsolt Parragi <zsolt.parragi@percona.com>)
List pgsql-hackers
On Mon, Sep 28, 2026 at 10:12:37PM +0000, Zsolt Parragi wrote:
> I was able to reproduce the issue both on windows, and on linux by
> "patching" the server to reproduce the described behavior.

How exactly?

> The overall changes look good to me, it just needs some
> squashing/organizing to be a proper patchset.

TBH, I am not completely sure what you are proposing here.  v1-0001
from Andrey and AI-generated-not-reviewed 0003 from Nikolay step on
each other with the latter patch requiring the former patch, in terms
of the way the last buffered error messages can be consumed, which
should be either something local to try_complete_step() or tracked by
IsoConnInfo.  I'm OK with the basic idea of having more predictible
output here, with some alternate outputs to make the CI happier on
Windows, let's just organize a bit the whole..

-       SELECT pg_terminate_backend(pid) FROM pg_stat_activity
+       SELECT pg_terminate_backend(pid, 180000) FROM pg_stat_activity

Avoiding hardcoded timeouts would be nice.  They are not liked on slow
machines.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Zsolt Parragi
Date:
Subject: Re: parallel autovacuum: Propagate track_cost_delay_timing to parallel workers
Next
From: Zsolt Parragi
Date:
Subject: Re: [PATCH v1] Fix for Bug#19724 - ALTER TYPE ... ALTER ATTRIBUTE triggers internal error for base type of domain with check