Request a Demo
Home   >   mailing lists

Re: [PATCH] Fix TAP tests with recent IPC::Run on Windows - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Fix TAP tests with recent IPC::Run on Windows
Date
Msg-id arr3KGsx0z7xhN-8@paquier.xyz
Whole thread
In response to Re: [PATCH] Fix TAP tests with recent IPC::Run on Windows  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Tree view 
On Mon, Sep 28, 2026 at 12:54:18PM -0400, Andrew Dunstan wrote:
> I think the right way is to have a wrapper function as in the attached, so
> instead of calling IPC::Run::run you would call ipc_run ...
>
> Note that this patch only touches the sites that will actually be affected
> by this. If we wanted to be consistent we would replace calls in a further
> 23 files.

That seems much better in the long-run, thanks.  The
ipc_run_text_mode() being published in Utils.pm does not seem
necessary, though.  This is a part that I'm sure could become
confusing if we allow code outside of Utils.pm to use it.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Fabrízio Mello
Date:
Subject: Add pg_stat_log_messages: cumulative statistics about server log messages (was: Add contrib module pg_stat_log: cumulative statistics about server log messages)
Next
From: Masahiko Sawada
Date:
Subject: Re: Parallel autovacuum: leader crashes when no DSM segment can be created