Re: run pgindent in CI - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: run pgindent in CI
Date
Msg-id arKtx76ROm1FhJIb@nathan
Whole thread
In response to run pgindent in CI  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: run pgindent in CI
Re: run pgindent in CI
List pgsql-hackers
On Tue, Sep 22, 2026 at 09:10:23AM +0200, Peter Eisentraut wrote:
> Previously discussed in [0].  People seemed to generally like the idea of
> running pgindent in CI but didn't want the job to fail outright if there
> were violations.  My proposal here is to use a combination of GitHub Actions
> features [1] to create job annotations and step summaries to create some
> kind of warning output.  I have attached an example screenshot.

+1.  I think it'd be nice if the commitfest app showed some sort of
indicator, too.

FWIW I've been using my own custom pgindent for a couple of months that is
much faster, which might be nice if we're going to start running it in CI.
I just haven't gotten to posting the patches.  The main ideas are 1)
running in parallel and 2) parsing typedefs.list once per run.  That pretty
dramatically decreases the duration of a whole-tree indent.

-- 
nathan



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Teach pg_upgrade to deal with invalid databases
Next
From: Heikki Linnakangas
Date:
Subject: Re: Catversion bumps during beta (was Re: [Proposal] Expose internal MultiXact member count function for efficient monitoring)