On Sat, Sep 12, 2026 at 02:00:00PM +0300, Alexander Lakhin wrote:
> Please look at the attached v3-Define-...patch, where I think I addressed
> all of your comments.
The ACL bits were slightly puzzling because it's the first time I see
this pattern in the code (following Tom's comment upthread also in
tsvector), and I indeed get much better error messages:
=# SELECT acldefault(E'\x80'::"char", 0);
ERROR: 22021: invalid byte sequence for encoding "UTF8": 0x80
=# SELECT acldefault(chr(1)::"char", 10);
ERROR: 22023: unrecognized object type abbreviation: "\001"
The second query just showed nothing originally.
For the typmods, %d is a better choice to me as the input is an
integer.
As a whole, that looks OK, so applied on HEAD. I did not look at
0002.
--
Michael
