Re: injection_points: canceled or terminated waiters leak their wait slots - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: injection_points: canceled or terminated waiters leak their wait slots
Date
Msg-id ar2VsK9d-UJiC7x7@paquier.xyz
Whole thread
In response to Re: injection_points: canceled or terminated waiters leak their wait slots  (Andrey Borodin <x4mmm@yandex-team.ru>)
List pgsql-hackers
On Wed, Sep 30, 2026 at 11:00:26PM +0500, Andrey Borodin wrote:
> I think there's more benefit than possible harm. There are ~4 similar
> failures a month on master. If we resurrect walreceiver problems, we will
> notice soon. There were like ~20 failures a month. And a8458f508a7 commit
> message looks promising (I do not understand commit itself).

Well, as mentioned in this commit, peeking at a socket before sleeping
is qualified as a kludge, probably not the best long-term approach.  I
doubt that a lot of people are motivated to redesign the event vs
socket handling just to make for a better socket implementation of
Postgres on WIN32, and I suspect that relying on Thomas's mage skills
should be good enough.  FWIW, I trust his skills, and also I have no
plans to dive into this leel of details for the WIN32 issues; there's
more than enough going on.

Now I don't mind running the revert/revert experiment and see how it
goes, at the condition that we make all the branches more stable as a
starting point.  Bypassing these tests on WIN32 is part of the plan
I'd be OK with.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] intXshr, intXshl: return error on shift count out of range
Next
From: Alex Liapychev
Date:
Subject: Re: COMMENTS are not being copied in CREATE TABLE LIKE