Re: test_aio: Fix broken error recovery assertions in 001_aio - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: test_aio: Fix broken error recovery assertions in 001_aio
Date
Msg-id aoY5qjW3HWvX59Xy@paquier.xyz
Whole thread
Responses Re: md5_password_warnings for password auth with MD5-encrypted passwords
Re: Logical Replication - revisit `is_table_publication` function implementation
List pgsql-hackers
On Wed, Aug 19, 2026 at 12:08:56PM +0200, Jelte Fennema-Nio wrote:
> The three error recovery checks in `test_handle()` used `qr/^|ok$/` to
> look for the `ok` marker column in psql's output. That is an alternation
> of `^` and `ok$`, and `^` matches every string, so the assertions passed
> no matter what psql printed.

Passing by..

Oops, /^|ok$/ with a '|' meaning OR in this context, or match all
strings.  That's clearly broken, yes.

Will check later and fix.  Thanks for the report.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: GIN page deletion and page recycling bugs
Next
From: Masahiko Sawada
Date:
Subject: Re: Logical replication row filter loses unchanged toasted columns