Re: Streamify more code paths - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: Streamify more code paths
Date
Msg-id anHWObuykWFpM6my@bdtpg
Whole thread
In response to Re: Streamify more code paths  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hi,

On Tue, Aug 04, 2026 at 08:41:35PM +0900, Michael Paquier wrote:
> On Tue, Aug 04, 2026 at 09:40:23AM +0300, Nazir Bilal Yavuz wrote:
> > On Mon, 3 Aug 2026 at 15:25, Mihail Nikalayeu <mihailnikalayeu@gmail.com> wrote:
> >> The simplest fix is to reorder a few lines of code - attached (with a
> >> test generated by Claude based on my instructions).
> > 
> > I agree with you, fix LGTM.
> 
> That seems sensible at first sight.  I am not really convinced by the
> need of a test, even if useful to prove your point.

+1. Also I think that the test as it is, is missing a teardown to drop the
tablespace. What could work is a global teardown to drop the tablespace and move
the drop table in a per session teardown.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Streamify more code paths
Next
From: David Rowley
Date:
Subject: Re: [PATCH] Use ssup_datum_*_cmp for int2, oid, and oid8 sort support