Re: Allow a condition string in an injection point - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Allow a condition string in an injection point
Date
Msg-id an6yuHhq-gJ2jNao@paquier.xyz
Whole thread
In response to Allow a condition string in an injection point  (Sami Imseih <samimseih@gmail.com>)
Responses Re: [PATCH v3] Add ssl_cert_files/ssl_key_files for multi-certificate support
List pgsql-hackers
On Thu, Aug 13, 2026 at 04:53:29PM -0500, Sami Imseih wrote:
> Yeah, you're right, local vs shared injection points tests don't
> really make a difference
> here. With that said, just because shared points are the more common
> case, I kept
> those instead.

Okay, that works here.  My previous point feels a bit moot due to
TestInjectionNoticeFunc, but that would be my fault.

> I do like the 051 test you mention and I think we should add a string
> to the "sync_slot" as well. This is good for demo.
> See attached 0002 for this.
>
> With that said, I think the stronger case for injection points string filters
> are tests in which we can't use set_local and we can do wait_for_event
> which is more robust that using regexp.

If others would like to be fancier, that could always happen later.
It does not change the fact that this stuff has merit in the long run.

Edited a couple of things, like comments, some ereport() vs elog().
And then applied both things.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: Row pattern recognition
Next
From: Álvaro Herrera
Date:
Subject: Re: Reduce padding in WALOpenSegment and XLogReaderState