Re: Fetch channel binding digest explicitly with OpenSSL 3.0 and later - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Fetch channel binding digest explicitly with OpenSSL 3.0 and later
Date
Msg-id an5jTmaE7n4q-Ib_@paquier.xyz
Whole thread
In response to Re: Fetch channel binding digest explicitly with OpenSSL 3.0 and later  (Mark Atwood <mark@reviewcommit.com>)
List pgsql-hackers
On Fri, Aug 14, 2026 at 09:23:28AM +0900, Fujii Masao wrote:
> In these cases, algo_name is NULL, so OBJ_nid2sn(algo_nid) is also
> NULL. That means NULL would be passed to %s in both elog() and
> libpq_append_conn_error().

And that's a very stupid thing to do.  Not sure what I was thinking
here..

> Isn't it better to use %d and pass algo_nid instead?

And that would be a better thing to do yes.  It's a nice copy-pasto
from the pre-3.0 path, which is not wrong as we derive the error from
a EVP_get_digestbynid().

Switching to the NID number in the report is the right call, will fix.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Vitaly Davydov
Date:
Subject: Re: Deadlock detector fails to activate on a hot standby replica
Next
From: Sami Imseih
Date:
Subject: Re: Report index currently being vacuumed in pg_stat_progress_vacuum