Re: Don't use pq_putmessage in socket comm function - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Don't use pq_putmessage in socket comm function
Date
Msg-id amB_gJ5m8SaPL3hC@paquier.xyz
Whole thread
In response to Don't use pq_putmessage in socket comm function  (Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>)
Responses Re: Don't use pq_putmessage in socket comm function
Re: Fix SPLIT PARTITION bound-overlap bug and other improvements
List pgsql-hackers
On Wed, Jul 22, 2026 at 10:16:53AM +0200, Anthonin Bonnefoy wrote:
> However, if a custom PqCommMethods is defined, any call to
> socket_putmessage_noblock will then loop to the custom putmessage.
>
> This patch fixes the issue by directly using socket_putmessage in
> socket_putmessage_noblock.

Yes, that's strange.  It seems like a mistake going down to 9.5, as of
2bd9e412f92b where socket_putmessage_noblock() has been introduced,
leaving the pq_putmessage() around.

Thoughts or opinions?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Antonin Houska
Date:
Subject: Re: Allow progress tracking of sub-commands
Next
From: Antonin Houska
Date:
Subject: Re: Unexpected behavior after OOM errors