Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench - Mailing list pgsql-committers

From Fabien COELHO
Subject Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench
Date
Msg-id alpine.DEB.2.22.394.2106270745290.482873@pseudo
Whole thread Raw
In response to pgsql: Fix pattern matching logic for logs in TAP tests of pgbench  (Michael Paquier <michael@paquier.xyz>)
List pgsql-committers
>> Seem quite unnecessary. We haven't found that to be an issue elsewhere
>> in the code where slurp_file is used. And in the present case we know
>> the file exists because we got its name from list_files().
>
> Agreed.  That's an exchange between a hard failure mid-test and a
> failure while letting the whole test run.  Here, we expect the test to
> find the log file all the time, so a hard failure does not sound like
> a bad thing to me either.

Ok, fine with me!

-- 
Fabien.



pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Doc: update v14 release notes for revert of commit c0cb87fbb.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Error message refactoring