Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench - Mailing list pgsql-committers

From Fabien COELHO
Subject Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench
Date
Msg-id alpine.DEB.2.22.394.2106261713440.482873@pseudo
Whole thread Raw
In response to Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-committers
>> However, if slurp_file fails it raises an exception and aborts the
>> whole TAP unexpectedly, which is pretty unclean. So I'd suggest to
>> keep the eval, as attached. I tested it by changing the file name so
>> that the slurp fails.
>
> Seem quite unnecessary. We haven't found that to be an issue elsewhere
> in the code where slurp_file is used. And in the present case we know
> the file exists because we got its name from list_files().

Fine with me!

-- 
Fabien.



pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench
Next
From: Tom Lane
Date:
Subject: pgsql: Remove undesirable libpq dependency on stringinfo.c.