Re: pgbench logging broken by time logic changes - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench logging broken by time logic changes
Date
Msg-id alpine.DEB.2.22.394.2106232158120.1601973@pseudo
Whole thread Raw
In response to Re: pgbench logging broken by time logic changes  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: pgbench logging broken by time logic changes
List pgsql-hackers
Ola Álvaro,

> ... or, actually, even better would be to use a TODO block, so that the
> test is run and reports its status, but if it happens not to succeed it
> will not cause the whole test to fail.  That way you'll accumulate some
> evidence that may serve to improve the test in the future until it
> works fully:
>
> TODO: {
>   local $TODO = "Ths test is unreliable";
>
>   ok(1.5 < $delay && $delay < 2.5, "-T 2 run around 2 seconds");
> }

Thanks for the hint! Why not, having the ability to collect data is a good 
thing, so attached v10 does that. If something go wrong, the TODO section 
could be extended around all calls.

-- 
Fabien.
Attachment

pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: Fix uninitialized copy_data var (src/backend/commands/subscriptioncmds.c)
Next
From: Corey Huinker
Date:
Subject: Re: Emit namespace in post-copy output