Re: Version reporting in pgbench - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: Version reporting in pgbench
Date
Msg-id alpine.DEB.2.22.394.2106182300170.3211875@pseudo
Whole thread Raw
In response to Re: Version reporting in pgbench  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Version reporting in pgbench
List pgsql-hackers
Hello Tom,

>> Why not move the printVersion call right after the connection is 
>> created, at line 6374?
>
> I started with that, and one of the 001_pgbench_with_server.pl
> tests fell over --- it was expecting no stdout output before a
> "Perhaps you need to do initialization" failure.  If you don't
> mind changing that,

Why would I mind?

> I agree that printing immediately after the connection is made is a bit 
> less astonishing.

Ok, so let's just update the test? Attached a proposal with the version 
moved.

Note that if no connections are available, then you do not get the 
version, which may be a little bit strange. Attached v3 prints out the 
local version in that case. Not sure whether it is worth the effort.

-- 
Fabien.
Attachment

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: A few nuances about specifying the timeline with START_REPLICATION
Next
From: Tom Lane
Date:
Subject: Re: Version reporting in pgbench