Re: Version reporting in pgbench - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: Version reporting in pgbench
Date
Msg-id alpine.DEB.2.22.394.2106182021570.3211875@pseudo
Whole thread Raw
In response to Version reporting in pgbench  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Version reporting in pgbench
List pgsql-hackers
Hello Tom,

> One point here is that printing the server version requires
> access to a connection, which printResults() hasn't got
> because we already closed all the connections by that point.
> I solved that by printing the banner during the initial
> connection that gets the scale factor, does vacuuming, etc.

Ok.

> If you're dead set on not printing the version till the end,
> that could be made to happen; but it's not clear to me that
> this way is any worse, and it's certainly easier.

pgbench (14beta1 dev 2021-06-12 08:10:44, server 13.3 (Ubuntu 13.3-1.pgdg20.04+1))

Why not move the printVersion call right after the connection is created, 
at line 6374?

Otherwise it works for me.

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Add version macro to libpq-fe.h
Next
From: Alvaro Herrera
Date:
Subject: Re: Failures with gcd functions with GCC snapshots GCC and -O3 (?)