Re: some more pg_dump refactoring - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: some more pg_dump refactoring
Date
Msg-id alpine.DEB.2.22.394.2007080640000.261743@pseudo
Whole thread Raw
In response to Re: some more pg_dump refactoring  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: some more pg_dump refactoring
List pgsql-hackers
Hallo Peter,

>>>> Would it make sense to accumulate in the other direction, older to newer,
>>>> so that new attributes are added at the end of the select?
>>> I think that could make sense, but the current style was introduced by
>>> daa9fe8a5264a3f192efa5ddee8fb011ad9da365.  Should we revise that?
>> It seems to me more logical to do it while you're at it, but you are the
>> one writing the patches:-)
>
> What do you think about this patch to reorganize the existing code from that 
> old commit?

I think it is a definite further improvement.

Patch applies cleanly, compiles, global & pg_dump tap test ok, looks ok to 
me.

-- 
Fabien.



pgsql-hackers by date:

Previous
From: "kato-sho@fujitsu.com"
Date:
Subject: RE: Performing partition pruning using row value
Next
From: Fabien COELHO
Date:
Subject: Re: Proposal: Automatic partition creation