Re: TAP testing for psql's tab completion code - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: TAP testing for psql's tab completion code
Date
Msg-id alpine.DEB.2.21.1912301144560.14206@pseudo
Whole thread Raw
In response to Re: TAP testing for psql's tab completion code  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: TAP testing for psql's tab completion code  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
>> That is what my patch does: it tests prompts, tab completion, help,
>> command options… and I added tests till I covered most psql source.
>
> Well, I think that where possible we ought to test using the existing 
> test infrastructure -- help, for example, seems like it could perfectly 
> well be tested in src/test/regress/sql/psql.sql, or we could move stuff 
> out to a new set of SQL test scripts under src/bin/psql/sql/,

I do not think it is a good idea, because help output is quite large, 
there are many of them, and we should certainly not want it stored 
repeatedly in output files for diffs. I rather trigger the output and only 
check for some related keywords, so that it fits TAP tests reasonably 
well.

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of largein-progress transactions
Next
From: Vik Fearing
Date:
Subject: Re: Recognizing superuser in pg_hba.conf