>> I'm not fan of relying on the configure stuff ("with_readline"), in my
>> Expect version I tested if history capabilities are available from psql
>> itself.
>
> No, I disagree with that. If configure thinks it built with readline,
> and then the actual binary acts like it doesn't have readline, that's
> a bug that we'd like the tests to detect.
Hmmm. Sure, that's a point.
What about running some tests on an installed version?
>> For the psql coverage patch, I was more ambitious and needed less
>> assumption about the configuration, I only forced -X.
>
> I mainly just duplicated the environment set up by PostgresNode::psql
> as much as it seemed reasonable to. The -At options are kind of
> irrelevant for what we're going to test here, probably, but why not
> keep the default behavior the same? I did drop -q since that
> suppresses prompting, and we probably want to test prompt.c using
> this infrastructure.
That is what my patch does: it tests prompts, tab completion, help,
command options… and I added tests till I covered most psql source.
--
Fabien.
