Re: fe-utils - share query cancellation code - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: fe-utils - share query cancellation code
Date
Msg-id alpine.DEB.2.21.1912031157110.653@pseudo
Whole thread Raw
In response to Re: fe-utils - share query cancellation code  (Michael Paquier <michael@paquier.xyz>)
Responses Re: fe-utils - share query cancellation code  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Bonjour Michaël,

>> Committed the patch after splitting things into two commits and after 
>> testing things from Linux and from a Windows console: the actual 
>> refactoring and the pgbench changes.
>
> I have found that we have a useless declaration of CancelRequested in 
> common.h, which is already part of cancel.h.

Ok.

> On top of that I think that we need to rework a bit the header 
> inclusions of bin/scripts/, as per the attached.

Looks fine to me: patch applies, compiles, runs.

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Allow relocatable extension to use @extschema@?
Next
From: Alvaro Herrera
Date:
Subject: Re: Using XLogFileNameP in critical section