Re: refactoring - share str2*int64 functions - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: refactoring - share str2*int64 functions
Date
Msg-id alpine.DEB.2.21.1908261103070.9896@lancre
Whole thread Raw
In response to Re: refactoring - share str2*int64 functions  (Michael Paquier <michael@paquier.xyz>)
Responses Re: refactoring - share str2*int64 functions  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Bonjour Michaël,

>> So I'll set out to write and use "pg_strtou?int64", i.e. 2 functions, and
>> then possibly generalize to lower sizes, 32, 16, depending on what is
>> actually needed.
>
> I am interested in this patch, and the next commit fest is close by.
> Are you working on an updated version?  If not, do you mind if I work
> on it and post a new version by the beginning of next week based on
> all the feedback gathered?

I have started to do something, and I can spend some time on that this 
week, but I'm pretty unclear about what exactly should be done.

The error returning stuff is simple enough, but I'm unclear about what to 
do with pg_uint64, which has a totally different signature. Should it be 
aligned?

-- 
Fabien Coelho - CRI, MINES ParisTech

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: pg11.5: ExecHashJoinNewBatch: glibc detected...double free orcorruption (!prev)
Next
From: "movead.li@highgo.ca"
Date:
Subject: Re: Re: Email to hackers for test coverage