improve PQexec documentation - Mailing list pgsql-hackers

From Fabien COELHO
Subject improve PQexec documentation
Date
Msg-id alpine.DEB.2.21.1904121016310.8912@lancre
Whole thread Raw
Responses Re: improve PQexec documentation
List pgsql-hackers
Hello devs,

I'm looking at psql's use of PQexec for implementing some feature.

When running with multiple SQL commands, the doc is not very helpful.

From the source code I gathered that PQexec returns the first COPY results 
if any, and if not the last non-empty results, unless all is empty in 
which case an empty result is returned. So * marks the returned result
in the following examples:

   INSERT ... \; * COPY ... \; SELECT ... \; \;
   SELECT ... \; UPDATE ... \; * SELECT ... \; \;
   \; \; * ;

The attached patch tries to improve the documentation based on my 
understanding.

IMVHO, psql's code is kind of a mess to work around this strange behavior, 
as there is a loop over results within PQexec, then another one after 
PQexec if there were some COPY.

-- 
Fabien.
Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [PATCH v20] GSSAPI encryption support
Next
From: Haribabu Kommi
Date:
Subject: Re: Attempt to consolidate reading of XLOG page