Hallo Peter,
>> In "xact.c", maybe I'd assign blockState in the else branch, instead of
>> overriding it?
>
> I think it was better the way it is, since logically the block state is
> first set, then set again after the new transaction starts.
Ok.
>> About the static _SPI_{commit,rollback} functions: I'm fine with these
>> functions, but I'm not sure about their name. Maybe
>> _SPI_chainable_{commit,rollback} would be is clearer about their content?
>
> I kept it as is, to mirror the names of the SQL commands.
Hmmm. Function _SPI_commit does not implement just COMMIT, it implements
both "COMMIT" and "COMMIT AND CHAIN"?
I'm fine with SPI_commit and SPI_commit_and_chain, and the rollback
variants.
Maybe _SPI_commit_chainable? Well, you do as you please.
--
Fabie
