Hello Alvaro,
>> - libpq internal function getHostaddr get a length,
>> and I added an assert about it.
>> - added a few braces on if/if/else/if/else/else
>> - added an UNKNOWN_HOST macro to hide "???"
>> - moved host_addr[] declaration earlier to avoid some braces
>
> You forgot to free(conn->connip) during freePGconn().
Argh, indeed:-(
> I found the UNKNOWN_HOST business quite dubious -- not only in your
> patch but also in the existing coding.
So did I:-) I only kept it because it was already done like that.
> I changed the getHostname API so that instead of returning "???" it sets
> the output buffer to the empty string.
I hesitated to do exactly that. I'm fine with that.
Thanks for the push.
--
Fabien.
