Re: Conflicting option checking in pg_restore - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: Conflicting option checking in pg_restore
Date
Msg-id alpine.DEB.2.21.1810290704490.5317@lancre
Whole thread Raw
In response to Re: Conflicting option checking in pg_restore  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Conflicting option checking in pg_restore  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hallå Daniel,

> an assertion?

v2 applies, compiles, both local & global make check are ok.

Its CF category could have been "bug fix" or "restructuring".

> [...] Perhaps, we don’t really test for all other potential 
> misconfigurations of the options so I can go either way.  It’s also a 
> cheap enough operation.  Do you think it should be a check like today or

Michaël suggests that there is no issue of external tool using the 
internal function, so I'm fine with this version.

I have switched the patch to ready for committer.

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Andrey Borodin
Date:
Subject: Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line
Next
From: Fabien COELHO
Date:
Subject: Re: why commutator doesn't work?