Re: libpq stricter integer parsing - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: libpq stricter integer parsing
Date
Msg-id alpine.DEB.2.21.1809111851510.13887@lancre
Whole thread Raw
In response to Re: libpq stricter integer parsing  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: libpq stricter integer parsing  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
>> +   <para>...</para>
>
> I would leave this out.  We don't need to document every single
> refinement of parsing rules.  This might better belong in the release notes.

Why not, I'd be fine with that. The fact that the libpq parser was quite 
fuzzy was not documented, the behavior was really a side effect of the 
implementation which never suggested that it would work.

>> +    appendPQExpBuffer(&conn->errorMessage,
>> +                      libpq_gettext("invalid value for keyword \"%s\"\n"),
>> +                      context);
>
> Add the actual invalid value to the error message.

Indeed.

Attached Michael's simplified version updated with your remarks.

-- 
Fabien.
Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: StandbyAcquireAccessExclusiveLock doesn't necessarily
Next
From: Andrew Dunstan
Date:
Subject: Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c)