Re: Progress reporting for pg_verify_checksums - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: Progress reporting for pg_verify_checksums
Date
Msg-id alpine.DEB.2.21.1809010728500.32764@lancre
Whole thread Raw
In response to Progress reporting for pg_verify_checksums  (Michael Banck <michael.banck@credativ.de>)
Responses Re: Progress reporting for pg_verify_checksums  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Hallo Michael,

> my colleague Bernd Helmle recently added progress reporting to our
> pg_checksums application[1]. I have now forward ported this to
> pg_verify_checksums for the September commitfest, please see the
> attached patch.

It seems that the patch does not apply cleanly on master, neither with 
"git apply" nor "patch". Could you rebase it?

> Here's the description:
>
> This optionally prints the progress of pg_verify_checksums via read
> kilobytes

MB? GB?

> to the terminal with the new command line argument -P.
>
> If -P was forgotten and pg_verify_checksums operates on a large cluster,
> the caller can send SIGUSR1 to pg_verify_checksums to turn progress
> status reporting on during runtime.

Hmmm. I cannot say I like the signal feature much. Would it make sense for 
the progress to be on by default, and to have a quiet option instead?

-- 
Fabien.


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: file cloning in pg_upgrade and CREATE DATABASE
Next
From: Fabien COELHO
Date:
Subject: Re: pg_verify_checksums -d option (was: Re: pg_verify_checksums -roption)