Re: Adding a note to protocol.sgml regarding CopyData - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: Adding a note to protocol.sgml regarding CopyData
Date
Msg-id alpine.DEB.2.21.1807301325100.16328@lancre
Whole thread Raw
In response to Adding a note to protocol.sgml regarding CopyData  (Tatsuo Ishii <ishii@sraoss.co.jp>)
Responses Re: Adding a note to protocol.sgml regarding CopyData
List pgsql-hackers
Hello Tatsuo-san,

Minor suggestions, although I'm not a native English speaker.

> In libpq.sgml following is stated:
>
>        Before <productname>PostgreSQL</productname> protocol 3.0, it was necessary
>        for the application to explicitly send the two characters
>        <literal>\.</literal> as a final line to indicate to the server that it

ISTM That "it" may refer to the server... Put "the application" instead?

> had
>        finished sending <command>COPY</command> data.  While this still works, it is deprecated and the
>        special meaning of <literal>\.</literal> can be expected to be removed in a
>        future release.

Maybe be more assertive, "will be removed"?

>  It is sufficient to call <function>PQendcopy</function> after

"It is now sufficient ..."?

>        having sent the actual data.
>
> I think this should be mentioned in protocol.sgml as well. Developers
> who wish to develop programs that understand frontend/backend protocol
> should be able to focus on protocol.sgml. Attached is a patch for
> this.


-- 
Fabien.


pgsql-hackers by date:

Previous
From: Alexander Kuzmenkov
Date:
Subject: Re: [HACKERS] PoC: full merge join on comparison clause
Next
From: Peter Eisentraut
Date:
Subject: Re: Making "COPY partitioned_table FROM" faster