Re: [HACKERS] [WIP] Zipfian distribution in pgbench - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: [HACKERS] [WIP] Zipfian distribution in pgbench
Date
Msg-id alpine.DEB.2.20.1711201656320.754@lancre
Whole thread Raw
In response to Re: [HACKERS] [WIP] Zipfian distribution in pgbench  (Alik Khilazhev <a.khilazhev@postgrespro.ru>)
Responses Re: [HACKERS] [WIP] Zipfian distribution in pgbench  (Alik Khilazhev <a.khilazhev@postgrespro.ru>)
List pgsql-hackers
Hello Alik,

Patch applies, compiles, works (I checked the distribution). Doc gen ok. 
make check ok.

> I have reduced range to [1, 10] and updated the test.

I would suggest to use [1, 9] and the simpler regex [1-9] instead of the 
full list.

Also, there should be an empty line between functions. I just noticed that 
one is missing after zipfFindOrCreateCacheCell().

-- 
Fabien.


pgsql-hackers by date:

Previous
From: Ildus Kurbangaliev
Date:
Subject: Re: [HACKERS] Custom compression methods
Next
From: Tomas Vondra
Date:
Subject: Re: [HACKERS] Custom compression methods