Re: [HACKERS] pgbench - minor fix for meta command only scripts - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: [HACKERS] pgbench - minor fix for meta command only scripts
Date
Msg-id alpine.DEB.2.20.1709120303290.8852@lancre
Whole thread Raw
In response to Re: [HACKERS] pgbench - minor fix for meta command only scripts  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: [HACKERS] pgbench - minor fix for meta command only scripts
Re: [HACKERS] pgbench - minor fix for meta command only scripts
List pgsql-hackers
Hello Jeff,

> Shouldn't we use pg_usleep to ensure portability?  it is defined for
> front-end code.  But it returns void, so the error check will have to be
> changed.

Attached v3 with pg_usleep called instead.

> I didn't see the problem before the commit I originally indicated , so I
> don't think it has to be back-patched to before v10.

Hmmm.... you've got a point, although I'm not sure how it could work 
without sleeping explicitely. Maybe the path was calling select with an 
empty wait list plus timeout, and select is kind enough to just sleep on 
an empty list, or some other miracle. ISTM clearer to explicitely sleep in 
that case.

-- 
Fabien.
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Still another race condition in recovery TAP tests
Next
From: Michael Paquier
Date:
Subject: [HACKERS] Removing wal_keep_segments as default configuration in PostgresNode.pm