Re: [HACKERS] merge psql ef/ev sf/sv handling functions - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: [HACKERS] merge psql ef/ev sf/sv handling functions
Date
Msg-id alpine.DEB.2.20.1709070716120.17848@lancre
Whole thread Raw
In response to Re: [HACKERS] merge psql ef/ev sf/sv handling functions  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> you can't do this sort of thing:
>
> -            psql_error("The server (version %s) does not support editing function source.\n",
> +            psql_error("The server (version %s) does not support editing %s.\n",
>                        formatPGVersionNumber(pset.sversion, false,
> -                                             sverbuf, sizeof(sverbuf)));
> +                                             sverbuf, sizeof(sverbuf)),
> +                       is_func ? "function source" : "view definitions");
>
> It's too much of a pain in the rear for translators.

Argh, indeed, I totally forgot about translations. Usually there is a _() 
hint for gettext.

> See 
> https://www.postgresql.org/docs/devel/static/nls-programmer.html#nls-guidelines 
> Usually we just use two independent messages, and that's what I did.

Yep, makes sense. Thanks for the fix.

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: [HACKERS] Restricting maximum keep segments by repslots
Next
From: Tatsuro Yamada
Date:
Subject: Re: [HACKERS] ANALYZE command progress checker