Re: [HACKERS] pgbench: Skipping the creating primary keys afterinitialization - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: [HACKERS] pgbench: Skipping the creating primary keys afterinitialization
Date
Msg-id alpine.DEB.2.20.1709060853360.17848@lancre
Whole thread Raw
In response to Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
Applies, compiles, works for me.

Very very minor comments that I should have noticed before, sorry for this 
additional round trip.

In the help line, move -I just after -i, to put short options in 
alphabetical and decreasing importance order. On this line, also add the 
information about the default, something like:
  -i, --ini...       ....  -I, --custom....=[...]+  (default "ctgvp")                     ...

When/if the pgbench tap test patch get through, the feature should be 
tested there as well. No action needed now.

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Tatsuro Yamada
Date:
Subject: Re: [HACKERS] CLUSTER command progress monitor
Next
From: Andres Freund
Date:
Subject: [HACKERS] Changing Jobs