Re: [HACKERS] pgbench tap tests & minor fixes - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: [HACKERS] pgbench tap tests & minor fixes
Date
Msg-id alpine.DEB.2.20.1706152107020.4597@lancre
Whole thread Raw
In response to Re: [HACKERS] pgbench tap tests & minor fixes  (Nikolay Shaplov <dhyan@nataraj.su>)
Responses Re: [HACKERS] pgbench tap tests & minor fixes
List pgsql-hackers
> As for me, I would do expr_scanner_chomp_substring(PsqlScanState, int, int&);
> that changes end_offset as desired...

Why not.

> And use it instead of end_offset = expr_scanner_offset(sstate) - 1;

I removed these?

> The second issue: you are removing all trailing \n and \r. I think you should
> remove only one \n at the end of the string, and one \r before \n if there was
> one.

So chomp one eol.

Is the attached version better to your test?

-- 
Fabien.
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] WIP: Data at rest encryption
Next
From: Andres Freund
Date:
Subject: Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors