Re: [HACKERS] [COMMITTERS] pgsql: Add missing support for new nodefields - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: [HACKERS] [COMMITTERS] pgsql: Add missing support for new nodefields
Date
Msg-id alpine.DEB.2.20.1703212146050.22754@lancre
Whole thread Raw
In response to Re: [HACKERS] [COMMITTERS] pgsql: Add missing support for new nodefields  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Hello Andres,

>> It is not done yet, but it looks that it can work in the end with limited
>> effort. Currently it works for copy & equal.
>
> It'd have to do out/read as well imo.

Sure. This part is WIP, though.

>> Is there some interest to generate the x00kB of sources rather than edit
>> them everytime, or forgetting it from time to time, or does everyone like it
>> as it is?
>
> From my POV yes.  But it's not quite as trivial as just generating it
> based on fields. Some fields are intentionally skipped, e.g. location,
> for equalfuncs, but not copy/out/readfuncs. So there needs to be a way
> to specify such special rules.

Indeed, I noticed these particularities... For some case it can be
automated with limited input. For really special cases (eg a few read/out
functions) , the script is told to skip some node types and the special
manual version is taken from the file instead of being generated.

--
Fabien.


pgsql-hackers by date:

Previous
From: Denish Patel
Date:
Subject: Re: [HACKERS] Monitoring roles patch
Next
From: Fabien COELHO
Date:
Subject: Re: [HACKERS] [COMMITTERS] pgsql: Add missing support for new nodefields