Re: pgbench - minor fix for meta command only scripts - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench - minor fix for meta command only scripts
Date
Msg-id alpine.DEB.2.20.1607110653460.12659@sto
Whole thread Raw
In response to Re: pgbench - minor fix for meta command only scripts  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: pgbench - minor fix for meta command only scripts
List pgsql-hackers
Hello Michaël,

> You may want to name your patches with .patch or .diff. Using .sql is
> disturbing style :)

Indeed! :-)

> Indeed, not reporting the progress back to the client in the case of a
> script with only meta commands is non-intuitive.
>
> This looks good to me. I'd just rewrite the comment block with
> something like that, more simplified:

Ok. Here is an updated version, with a better suffix and a simplified
comment.

Thanks,

--
Fabien.
Attachment

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: Logical decoding
Next
From: Michael Paquier
Date:
Subject: Re: [COMMITTERS] Logical decoding