Re: extend pgbench expressions with functions - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: extend pgbench expressions with functions
Date
Msg-id alpine.DEB.2.10.1603290725340.14994@sto
Whole thread Raw
In response to Re: extend pgbench expressions with functions  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
>> I guess the question here is whether we want the part-c patch, which
>> removes the historical \setrandom syntax.  That's technically no
>> longer needed since we now can use random() as a function directly
>> inside \set commands, but we might want it anyway for backward
>> compatibility.

This patch is indeed a proposal.

>> Anybody have an opinion on that?
>
> +1 for nuking it. That's not worth the trouble maintaining it.

I share Michaël opinion.

Some arguments for removing it:
 - \setrandom is syntactically inhomogeneous in the overall syntax,   and is now redundant
 - switching to the \set syntax is pretty easy, see attached script
 - custom scripts are short, they are used by few but   advance users, for which updating would not be an issue
 - the parsing & execution codes are lengthy, repetitive...

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Sync tzload() and tzparse() APIs with IANA release tzcode2016c.
Next
From: Michael Paquier
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Sync tzload() and tzparse() APIs with IANA release tzcode2016c.