Re: extend pgbench expressions with functions - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: extend pgbench expressions with functions
Date
Msg-id alpine.DEB.2.10.1601281016400.27415@sto
Whole thread Raw
In response to Re: extend pgbench expressions with functions  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
>> I do not think that it is really worth fixing, but I will not prevent anyone
>> to fix it.
>
> I still think it does. Well, if there is consensus to address this one
> and optionally the other integer overflows even on back branches, I'll
> write a patch and let's call that a deal. This is not a problem from
> my side.

My point is just about the cost-benefit of fixing a low probability issue 
that you can only encounter if you are looking for it, and not with any 
reasonable bench script.

Now adding somewhere a test might just help closing the subject and 
do more useful things, so that would also be a win.
  /* these would raise an arithmetic error */  if (lval == INT64_MIN && rval == -1)  {     fprintf(stderr, "cannot
divideor modulo INT64_MIN by -1\n");     return false;  }
 

This may be backpatched to old supported versions.

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Minor code improvements to create_foreignscan_plan/ExecInitForeignScan
Next
From: Bruce Momjian
Date:
Subject: Re: Template for commit messages