Re: pgbench - allow backslash-continuations in custom scripts - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench - allow backslash-continuations in custom scripts
Date
Msg-id alpine.DEB.2.10.1507251652120.25082@sto
Whole thread Raw
In response to Re: pgbench - allow backslash-continuations in custom scripts  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
List pgsql-hackers
<oops, sorry, stalled post because of wrong from, posting again...>

> Attatched is the revised version of this patch.
>
> The first patch is not changed from before.
>
> The second is fixed a kind of bug.
>
> Ths third is the new one to allow backslash continuation for
> backslash commands.

Ah, thanks:-)

Would you consider adding the patch to the next commitfest? I may put 
myself as a reviewer...

> [...] I'm not satisfied by the design but I don't see another way..

I'll try to have a look.

>>> I don't have idea how to deal with the copy of psqlscan.[lh] from
>>> psql. Currently they are simply the dead copies of those of psql.
>>
>> I think that there should be no copies, but it should use relative
>> symbolic links so that the files are kept synchronized.
>
> Yeah, I think so but symlinks could harm on git and Windows.
> The another way would be make copies it from psql directory. They live 
> next door to each other.

Indeed there are plenty of links already which are generated by makefiles 
(see src/bin/pg_xlogdump/*), and probably a copy is made on windows. There 
should no file duplication within the source tree.

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pg_dump -Fd and compression level
Next
From: Tom Lane
Date:
Subject: Debugging buildfarm pg_upgrade check failures