Re: PATCH: remove nclients/nthreads constraint from pgbench - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: PATCH: remove nclients/nthreads constraint from pgbench
Date
Msg-id alpine.DEB.2.10.1507021456050.5962@sto
Whole thread Raw
In response to Re: PATCH: remove nclients/nthreads constraint from pgbench  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
> This doesn't behave correctly if you set -j to greater than -c, and also use 
> the rate limit option:
> [...]
>
> I think that can be fixed by just setting nthreads internally to nclients, if 
> nthreads > nclients. But please double-check that the logic used to calculate 
> throttle_delay makes sense in general, when nthreads is not a multiple of 
> nclients.

Indeed, I probably did not consider nthreads > nclients. The fix you 
suggest seems ok. I'll check it before sending a new v3.

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Support for N synchronous standby servers - take 2
Next
From: Andrew Dunstan
Date:
Subject: Re: raw output from copy