Re: PATCH: pgbench - logging aggregated info and transactions at the same time - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: PATCH: pgbench - logging aggregated info and transactions at the same time
Date
Msg-id alpine.DEB.2.10.1505021048190.30090@sto
Whole thread Raw
In response to Re: PATCH: pgbench - logging aggregated info and transactions at the same time  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers

> In doLog, the sample rate test should be mixed in the tlogfile condition
> so as to avoid calling rand if there is no logging anyway.
>
>  if (tlogfile && sample_rate != 0 && ...)

Oops, wrong logic. Rather:
  if (tlogfile && (sample_rate == 0 || ... random stuff))

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: PATCH: pgbench - logging aggregated info and transactions at the same time
Next
From: Andrew Dunstan
Date:
Subject: Re: CTE optimization fence on the todo list?