Re: run xmllint during build (was Re: need xmllint on borka) - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: run xmllint during build (was Re: need xmllint on borka)
Date
Msg-id alpine.DEB.2.10.1409140926540.29881@sto
Whole thread Raw
In response to Re: run xmllint during build (was Re: need xmllint on borka)  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: run xmllint during build (was Re: need xmllint on borka)
List pgsql-hackers
Hello Peter,

> I've committed the $(missing) use separately,

That was simple and is a definite improvement.

Tiny detail: the new DBTOEPUB macro definition in "src/Makefile.global.in" 
lacks another tab to be nicely aligned with the other definitions.

> and rebased this patch on top of that.

Applied and tested, everything looks fine.

The only remaining question is whether the xmllint check should always be 
called. You stated that it was stricter than sgml processing, so I would 
think it worth to always call it, but this is really a marginal 
preference. I think it is okay if some slaves in the build farm do build 
the various targets.

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Atri Sharma
Date:
Subject: Re: Postgres code for a query intermediate dataset
Next
From: Mark Kirkwood
Date:
Subject: Re: Postgres code for a query intermediate dataset