Re: gaussian distribution pgbench -- splits v4 - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: gaussian distribution pgbench -- splits v4
Date
Msg-id alpine.DEB.2.10.1407290937410.12870@sto
Whole thread Raw
In response to Re: gaussian distribution pgbench -- splits v4  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: gaussian distribution pgbench -- splits v4  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
Hello Robert,

>>> 3. Similarly, I suggest that the use of gaussian or uniform be an
>>> error when argc < 6 OR argc > 6.  I also suggest that the
>>> parenthesized distribution type be dropped from the error message in
>>> all cases.
>>
>> I wish to agree, but my interpretation of the previous code is that they
>> were ignored before, so ISTM that we are stuck with keeping the same
>> unfortunate behavior.
>
> I don't agree.

Attached B patch does turn incorrect setrandom syntax into errors instead 
of ignoring extra parameters.

First A patch is repeated to help commitfest references.

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Marti Raudsepp
Date:
Subject: Re: delta relations in AFTER triggers
Next
From: Pavel Stehule
Date:
Subject: Re: delta relations in AFTER triggers