Re: Patch to add regression tests for SCHEMA - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: Patch to add regression tests for SCHEMA
Date
Msg-id alpine.DEB.2.02.1307171032020.3991@localhost6.localdomain6
Whole thread Raw
In response to Re: Patch to add regression tests for SCHEMA  (Robins Tharakan <tharakan@gmail.com>)
List pgsql-hackers
I've looked this version.

The only reservation I have is that when changing the owner of a schema, 
the new owner is not always checked. I would suggest to query the new 
owner to check that it matches (5, 11, 12), just as you do in 3.

Also, reowning is tested several times (5, 11, 12). I would suggest to 
remove 12 which does not bring much new things after both 5 and 11 get 
passed ?

Otherwise the patch applies (with a minor warning about spaces on line 33) 
passes for me, and brings valuable new test coverage.

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: [PATCH] pgbench --throttle (submission 7 - with lag measurement)
Next
From: Greg Smith
Date:
Subject: Re: [PATCH] pgbench --throttle (submission 7 - with lag measurement)